Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Tableau Documentation #1989

Merged
merged 2 commits into from
Jan 18, 2021
Merged

Update Tableau Documentation #1989

merged 2 commits into from
Jan 18, 2021

Conversation

WinnyTroy
Copy link
Contributor

@WinnyTroy WinnyTroy commented Jan 12, 2021 •
edited
Loading

Changes / Features implemented

Updated Tableau Documentation

Closes #1885

ivermac
ivermac previously approved these changes Jan 12, 2021
View reviewed changes
Copy link
Contributor

@ivermac ivermac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@DavisRayM
Copy link
Contributor

DavisRayM commented Jan 12, 2021 •
edited
Loading

Looks good. We should look into a way to add it either into the index.rst file or the side menu bar.... at the moment it doesn't seem to easy to navigate to.

Screenshot 2021-01-12 at 16 15 40

@WinnyTroy WinnyTroy force-pushed the tableau_documentation branch 3 times, most recently from eccca21 to 0a363ae Compare January 13, 2021 08:58
DavisRayM
DavisRayM previously approved these changes Jan 14, 2021
View reviewed changes
@WinnyTroy WinnyTroy force-pushed the tableau_documentation branch 4 times, most recently from b52b4e2 to 105c89e Compare January 15, 2021 14:54
ukanga
ukanga reviewed Jan 15, 2021
View reviewed changes
Copy link
Member

@ukanga ukanga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, please fix the failing tests on CI.

@WinnyTroy WinnyTroy force-pushed the tableau_documentation branch 2 times, most recently from 70de39a to 543703c Compare January 18, 2021 07:33
@DavisRayM DavisRayM merged commit a077c42 into master Jan 18, 2021
@DavisRayM DavisRayM deleted the tableau_documentation branch January 18, 2021 09:29
@DavisRayM DavisRayM mentioned this pull request Jan 20, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ukanga ukanga ukanga approved these changes

@DavisRayM DavisRayM DavisRayM left review comments

@ivermac ivermac ivermac left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unpack nested repeat data in tableau
4 participants
@WinnyTroy @DavisRayM @ukanga @ivermac